Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): add eas registry contract #259

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat(contracts): add eas registry contract #259

merged 1 commit into from
Aug 14, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Aug 13, 2024

  • Add BaseRegistry contract
  • Add EASRegistry contract
  • Add tests

@0xmad 0xmad added the enhancement New feature or request label Aug 13, 2024
@0xmad 0xmad self-assigned this Aug 13, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 5:22pm

@0xmad 0xmad force-pushed the feature/registry branch from 0d4808b to 4a3beec Compare August 13, 2024 22:24
@0xmad 0xmad marked this pull request as ready for review August 14, 2024 04:16
ctrlc03
ctrlc03 requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some comments

packages/contracts/contracts/interfaces/IRecipientRegistry.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/BaseRegistry.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/EASRegistry.sol Outdated Show resolved Hide resolved
@0xmad 0xmad force-pushed the feature/registry branch from 4a3beec to f7a53e2 Compare August 14, 2024 15:53
@0xmad 0xmad requested a review from ctrlc03 August 14, 2024 15:53
@0xmad 0xmad force-pushed the feature/registry branch from f7a53e2 to a8efca7 Compare August 14, 2024 15:57
@0xmad 0xmad force-pushed the feature/registry branch from a8efca7 to b931f1a Compare August 14, 2024 16:35
@0xmad
feat(contracts): add eas registry contract
dc46823 
- [x] Add BaseRegistry contract
- [x] Add EASRegistry contract
- [x] Add tests
@0xmad 0xmad force-pushed the feature/registry branch from b931f1a to dc46823 Compare August 14, 2024 17:18
ctrlc03
ctrlc03 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ctrlc03 ctrlc03 enabled auto-merge August 14, 2024 17:53
@ctrlc03 ctrlc03 merged commit 0e750c4 into main Aug 14, 2024
13 checks passed
@ctrlc03 ctrlc03 deleted the feature/registry branch August 14, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@0xmad 0xmad

Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @ctrlc03